https://github.com/banach-space approved this pull request. LGTM, thanks for addressing my comments! Please address the final comments from Nicolas before landing this :) https://github.com/llvm/llvm-project/pull/68567