https://github.com/nicolasvasilache approved this pull request. Generally looks good thanks! Approving eagerly, please address the last 2 comments in the tests. https://github.com/llvm/llvm-project/pull/68567