[Mlir-commits] [flang] [mlir] Make MLIR Value more consistent in terms of `const` "correctness" (NFC) (PR #72765)

Mehdi Amini llvmlistbot at llvm.org
Wed Nov 22 14:49:21 PST 2023


================
@@ -335,8 +335,9 @@ namespace llvm {
     MutableArrayRef(T *begin, T *end) : ArrayRef<T>(begin, end) {}
 
     /// Construct a MutableArrayRef from a SmallVector.
-    /*implicit*/ MutableArrayRef(SmallVectorImpl<T> &Vec)
-    : ArrayRef<T>(Vec) {}
+    template <typename U>
+    /*implicit*/ MutableArrayRef(const SmallVectorTemplateCommon<T, U> &Vec)
+        : ArrayRef<T>(Vec) {}
----------------
joker-eph wrote:

We can also look at the change I make on the `Value` class: I'm making some API const that weren't const before and vice-versa ; without C++ unit-test to enforce the difference here right now...

https://github.com/llvm/llvm-project/pull/72765


More information about the Mlir-commits mailing list