dwblaikie wrote: Generally when we split things up, they're separate reviews and separate commits. fixups are for necessary changes that need to be applied atomically (fixes to the base patch in a pull request, etc). https://github.com/llvm/llvm-project/pull/73000