[Mlir-commits] [mlir] [mlir][LLVM] Support `immargs` in LLVM_IntrOpBase intrinsics (PR #73013)

[Benjamin Maxwell]

================
@@ -1276,7 +1276,7 @@ struct VectorScalableInsertOpLowering
   matchAndRewrite(vector::ScalableInsertOp insOp, OpAdaptor adaptor,
                   ConversionPatternRewriter &rewriter) const override {
     rewriter.replaceOpWithNewOp<LLVM::vector_insert>(
-        insOp, adaptor.getSource(), adaptor.getDest(), adaptor.getPos());
+        insOp, adaptor.getDest(), adaptor.getSource(), adaptor.getPos());
----------------
MacDue wrote:

I'm not sure what extra test I could add? This is tested via the intrinsic being correctly imported/exported to LLVM. If the order is wrong an assert is hit in the generated import/export logic. This is just the one place in MLIR where the builder for the intrinsic is used. 

https://github.com/llvm/llvm-project/pull/73013