[Mlir-commits] [mlir] [mlir][spirv] Add basic arithmetic folds (PR #71414)

Jakub Kuderski llvmlistbot at llvm.org
Tue Nov 21 12:07:44 PST 2023


kuhar wrote:

Wow, thanks for contributing this @inbelic!

> Not sure on the commit granularity, but happy to rebase if we should have it more/less commits.

Yes, splitting into multiple smaller PRs will make this much easier to review. I'd keep them at the level of granularity of up to a few related ops (for example logical ops like and/or can go together, signed/unsigned variants of the same operation, etc.).

> Additionally, I plan to add the various the integer comparison ops for logical as well. But I will ask for review now to make sure it looks good so far.

SG!



https://github.com/llvm/llvm-project/pull/71414


More information about the Mlir-commits mailing list