[Mlir-commits] [mlir] Revert "[mlir][vector] Move transpose with unit-dim to shape_cast pattern (#72493)" (PR #72918)

[Stella Laurenzo]

stellaraccident wrote:

I think there are two separate issues here:

1. There is a bar for what makes something a canonicalization which I am not hearing consensus on. I think that alone justifies a revert and further discussion. The price of just landing things by PR vs RFC or broader discussion for things like this is that we have to have a low cost path to revert when we mis-judge consensus. 
2. Getting a SPIR-V conversion test which exercises this is a good thing to do. Thank you for identifying it.

This particular patch was reverted because of point 1. The bar for canonicalization specifically is universal accessibility and agreement that the form being canonicalized to is actually "canonical". Both are judgment calls and a matter of design.

https://github.com/llvm/llvm-project/pull/72918