[Mlir-commits] [mlir] [mlir][tensor] Add a tensor.concat operation (PR #72779)

[Nicolas Vasilache]

================
@@ -77,6 +77,10 @@ struct TestTensorTransforms
       llvm::cl::desc("Test folding ops into tensor.pack and tensor.unpack"),
       llvm::cl::init(false)};
 
+  Option<bool> testDecomposeConcat{
----------------
nicolasvasilache wrote:

In general, I think we should move to transform ops for everything that requires such custom C++ test logic and make sense as a transform op.
C++ tests that are modeled like this one:
  1. are throwaway and never used outside of test, at least transforms are reusable.
  2. are opaque and hidden behind a name, at least transforms make the action of the test very clear.
  3. have intertwined `runOnOperation` implementation that just keeps on growing

https://github.com/llvm/llvm-project/pull/72779