[Mlir-commits] [mlir] [mlir] Add narrow type emulation conversions (PR #72181)

[llvmlistbot at llvm.org]

================
@@ -35,36 +36,98 @@ using namespace mlir;
 /// Return the bit offset of the value at position `srcIdx`. For example, if
 /// `sourceBits` equals to 4 and `targetBits` equals to 8, the x-th element is
 /// located at (x % 2) * 4. Because there are two elements in one i8, and one
-/// element has 4 bits.
+/// element has 4 bits. If `rightOffset` is true, return the offset from the
+/// right side of the `dstBits` container instead of the left side.
----------------
MaheshRavishankar wrote:

This is confusing. I'd rather have two methods `getLeftOffset...` and `getRightOffset...` (also maybe its worth finding something better than left and right)

https://github.com/llvm/llvm-project/pull/72181