[Mlir-commits] [mlir] [mlir][python] automatically bundle builtin dialect with core sources (PR #72338)

Stella Laurenzo llvmlistbot at llvm.org
Tue Nov 14 19:54:16 PST 2023


stellaraccident wrote:

> Why can't the just depend on the built-in dialect? That's what iree does: https://github.com/openxla/iree/blob/98e31728b7765664a0a87e5e9eeec76936548ff3/compiler/bindings/python/CMakeLists.txt#L142
> 
> (It is also picky about only depending on dialects or cares about and enumerates then explicitly)



> Yeah, I'm not sure exactly what regressed here and why... Reading some code

I don't think that early exit is right. It is perfectly fine to use the python API without generated dialect helper modules. Trying to load the helper module may make sense but not sure why it is required.

https://github.com/llvm/llvm-project/pull/72338


More information about the Mlir-commits mailing list