[Mlir-commits] [mlir] [mlir] Remove convertible identity restriction for memref.atomic_rmw … (PR #72262)

[llvmlistbot at llvm.org]

================
@@ -1562,8 +1562,6 @@ struct AtomicRMWOpLowering : public LoadStoreOpLowering<memref::AtomicRMWOp> {
   LogicalResult
   matchAndRewrite(memref::AtomicRMWOp atomicOp, OpAdaptor adaptor,
                   ConversionPatternRewriter &rewriter) const override {
-    if (failed(match(atomicOp)))
----------------
MaheshRavishankar wrote:

It seems like this only works for strided memref types. Can you check that `getStridesAndOffset` on the source type returns `success`, i.e. return failure when that method fails. I looked into the implementation of `getStridedElementPtr` and it asserts if thats not the case, so letting that through would lead to an assert

https://github.com/llvm/llvm-project/pull/72262