[Mlir-commits] [mlir] [mlir] Remove convertible identity restriction for memref.atomic_rmw … (PR #72262)

[llvmlistbot at llvm.org]

================
@@ -1562,8 +1562,6 @@ struct AtomicRMWOpLowering : public LoadStoreOpLowering<memref::AtomicRMWOp> {
   LogicalResult
   matchAndRewrite(memref::AtomicRMWOp atomicOp, OpAdaptor adaptor,
                   ConversionPatternRewriter &rewriter) const override {
-    if (failed(match(atomicOp)))
----------------
Max191 wrote:

> I actually dont understand this check..... This looks OK to me, but what was stopped by this change?

It fails when the memref type has an offset because it checks that the memref type has an identity map. But the pattern can handle offsets, so it should be fine to remove the check

https://github.com/llvm/llvm-project/pull/72262