[Mlir-commits] [mlir] [MLIR] Add support for frame pointers in MLIR (PR #72145)

Radu Salavat llvmlistbot at llvm.org
Tue Nov 14 08:06:17 PST 2023


Radu2k wrote:

Thanks for the valuable feedback! 

Regarding @zero9178's proposal, it's important to note that this value is an enum, limited to specific values. There are three potential approaches for implementation:

1. Use a Separate Enum Type: This is the existing approach. Continue using the enum to ensure only permissible values are used. Implementation across the code is managed through autogenerated functions.
2. Dictionary Array Attribute: Can we maintain this with the dictionary array attribute?
3. String Attribute: Would it be more appropriate to define this as a string attribute?

https://github.com/llvm/llvm-project/pull/72145


More information about the Mlir-commits mailing list