[Mlir-commits] [mlir] [mlir] Remove convertible identity restriction for memref.atomic_rmw … (PR #72262)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Nov 14 06:57:24 PST 2023


Max191 wrote:

`memref.atomic_rmw` will fail for memref types that have an offset because they do not have identity maps. However, I don't see why this restriction is needed, and this restriction causes some cases to fail to lower to LLVM. `memref.store` has no such restriction, and the conversion for store is the same as atomic_rmw.

Unless there was a reason for having the restriction there, it would be good to remove it to unblock some lowerings, especially once https://github.com/llvm/llvm-project/pull/72181 lands and the narrow type emulation of `memref.store` starts introducing `memref.atomic_rmw`

https://github.com/llvm/llvm-project/pull/72262


More information about the Mlir-commits mailing list