[Mlir-commits] [mlir] [mlir][python] add type wrappers (PR #71218)

[Oleksandr Alex Zinenko]

https://github.com/ftynse commented:

This looks nice from code readability perspective, especially if generalized to be used more pervasively.

My overall thinking here is that we want to delimit optional "sugar" from fundamental APIs, and make sure unsugared APIs are still usable. Any thoughts on how to make this clear?

I'm not sure how much of this should be treated as sugar, maybe we can just have a "types" object in dialect that contains such constructor functions?

Overall, this also needs more documentation. Both docstrings and overall design in https://mlir.llvm.org/docs/Bindings/Python/. (btw, magic value downcasting should also be described there).

https://github.com/llvm/llvm-project/pull/71218