[Mlir-commits] [mlir] [mlir][vector] Extend TransferReadDropUnitDimsPattern to support partially-static memrefs (PR #72142)

[Benjamin Maxwell]

https://github.com/MacDue commented:

This seems reasonable to me :). The docs you link seem to say this is allowed, as this is only removing statically known unit dims. The added `shape_cast` won't be something that can be lowered, but should (hopefully) fold away. 

https://mlir.llvm.org/docs/Dialects/MemRef/#memrefsubview-memrefsubviewop
> A subview operation may additionally reduce the rank of the resulting view by removing dimensions that are statically known to be of size 1.






https://github.com/llvm/llvm-project/pull/72142