[Mlir-commits] [mlir] [MLIR] Add support for frame pointers in MLIR (PR #72145)

[Christian Ulmann]

https://github.com/Dinistro commented:

Thanks for this extension 😄 

The code is looking fine, modulo a formatting issue (I suggest to either enable auto-formatting or setting up a pre-commit hock with clang-tidy-diff).
I do agree with @zero9178 on the skepticism of adding this to the custom assembly format. Keeping it in the attribute dictionary seems to be enough, considering that this will not be used by all users of `LLVMFuncOp`. 

https://github.com/llvm/llvm-project/pull/72145