[Mlir-commits] [mlir] [MLIR] Add support for frame pointers in MLIR (PR #72145)

[Markus Böck]

https://github.com/zero9178 commented:

Thank you for working on this! I think this looks mostly good but left some comments in the code.

I only have one high level question: Is it necassary to define a custom syntax for frame pointers within `llvm.func` or could it just be printed as part the dictionary attribute of `llvm.func`? 

I personally believe that `llvm.func`s syntax has gained too much custom syntax for function attributes that are simply not required. With the growing number of LLVM function attributes being added and implemented I also fear that this could get out of hand. 
Lastly it would also be less code :)

Adding some other reviewers as well 

https://github.com/llvm/llvm-project/pull/72145