[Mlir-commits] [mlir] [mlir][memref] Detect negative `offset` or `size` for `subview` (PR #72059)

Rik Huijzer llvmlistbot at llvm.org
Mon Nov 13 00:15:20 PST 2023


rikhuijzer wrote:

> This looks like a good fix for the verifier, but we should also fix the canonicalization to **not** create invalid IR!

Then I think that I'll implement the suggestions from Matthias in this PR and leave the canonicalization for a future PR. For that future PR, could you tell me what the preferred result would be? What would be the valid IR here that the canonicalization should return?

https://github.com/llvm/llvm-project/pull/72059


More information about the Mlir-commits mailing list