[Mlir-commits] [mlir] [mlir][gpu] Introduce `gpu.dynamic_shared_memory` Op (PR #71546)

[Mehdi Amini]

================
@@ -433,6 +433,34 @@ def GPU_GPUFuncOp : GPU_Op<"func", [
   let hasVerifier = 1;
 }
 
+def GPU_DynamicSharedMemoryOp : GPU_Op<"dynamic_shared_memory", 
+  [ParentOneOf<["GPUFuncOp", "LaunchOp", 
+                "mlir::LLVM::LLVMFuncOp", "mlir::func::FuncOp"]>]>
----------------
joker-eph wrote:

The verifier seems a bit overkill to me: I should be able to write my own kernel function I think?


Also this looks like it should be an operation without side-effects, but then I should also be able to sink it which would break the "getParent" here.

Can we get away with this verifier check and make the client code safe instead?

https://github.com/llvm/llvm-project/pull/71546