[Mlir-commits] [mlir] [mlir][vector] Notify the rewriter when sinking out of warp ops (PR #71964)
Jakub Kuderski
llvmlistbot at llvm.org
Fri Nov 10 10:38:24 PST 2023
================
@@ -713,6 +718,8 @@ struct WarpOpConstant : public OpRewritePattern<WarpExecuteOnLane0Op> {
auto dense = dyn_cast<SplatElementsAttr>(constantOp.getValue());
if (!dense)
return failure();
+ // Notify the rewriter that the warp op is changing.
+ rewriter.startRootUpdate(warpOp);
----------------
kuhar wrote:
Later, would be nice to wrap it with `make_scope_exit(...)`, to account for all the exits, but that can be a cleanup PR.
https://github.com/llvm/llvm-project/pull/71964
More information about the Mlir-commits
mailing list