[Mlir-commits] [mlir] [mlir][vector] Notify the rewriter when sinking out of warp ops (PR #71964)

[Jakub Kuderski]

================
@@ -894,6 +904,11 @@ struct WarpOpTransferRead : public OpRewritePattern<WarpExecuteOnLane0Op> {
       return failure();
 
     rewriter.replaceAllUsesWith(distributedVal, newRead);
+    if (hasMask) {
+      // Notify the rewriter that the warp op is changing.
+      rewriter.startRootUpdate(warpOp);
----------------
kuhar wrote:

Could you put that in the comment? This seems like some spooky-action-at-a-distance, so it would be worth to capture the reasoning. 

https://github.com/llvm/llvm-project/pull/71964