[Mlir-commits] [mlir] [mlir][vector] Notify the rewriter when sinking out of warp ops (PR #71964)

[Quinn Dawkins]

================
@@ -894,6 +904,11 @@ struct WarpOpTransferRead : public OpRewritePattern<WarpExecuteOnLane0Op> {
       return failure();
 
     rewriter.replaceAllUsesWith(distributedVal, newRead);
+    if (hasMask) {
+      // Notify the rewriter that the warp op is changing.
+      rewriter.startRootUpdate(warpOp);
----------------
qedawkins wrote:

We're actually not changing the op in any way. We're only replacing one of its uses with something outside the op, so this is just to notify the rewriter that the op "changed" (because we have some cleanup patterns to drop dead results).

https://github.com/llvm/llvm-project/pull/71964