[Mlir-commits] [mlir] [mlir] Add llvm.linker.options operation to the LLVM IR Dialect (PR #71720)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 5aa934e2af8727852dec0ec1cfa0cba05d858f70 a42a125705291daabf79a2efd77a6ad33b63fce0 -- mlir/include/mlir/Target/LLVMIR/ModuleImport.h mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp mlir/lib/Target/LLVMIR/ModuleImport.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
index 27e79ab5d611..691651199cdf 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -3072,7 +3072,6 @@ struct LLVMOpAsmDialectInterface : public OpAsmDialectInterface {
 };
 } // namespace
 
-
 //===----------------------------------------------------------------------===//
 // LinkerOptionsOp
 //===----------------------------------------------------------------------===//
@@ -3080,7 +3079,7 @@ struct LLVMOpAsmDialectInterface : public OpAsmDialectInterface {
 LogicalResult LinkerOptionsOp::verify() {
   if (mlir::Operation *parentOp = (*this)->getParentOp();
       parentOp && !satisfiesLLVMModule(parentOp))
-      return emitOpError("must appear at the module level");
+    return emitOpError("must appear at the module level");
   return success();
 }
 
diff --git a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
index 29fc1a19b318..ef9f33b414d8 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
@@ -172,20 +172,22 @@ convertCallLLVMIntrinsicOp(CallIntrinsicOp op, llvm::IRBuilderBase &builder,
   return success();
 }
 
-static void convertLinkerOptionsOp(ArrayAttr options, llvm::IRBuilderBase &builder,
+static void convertLinkerOptionsOp(ArrayAttr options,
+                                   llvm::IRBuilderBase &builder,
                                    LLVM::ModuleTranslation &moduleTranslation) {
-    llvm::Module *llvmModule = moduleTranslation.getLLVMModule();
-    llvm::LLVMContext &context = llvmModule->getContext();
-    llvm::NamedMDNode *linkerMDNode = llvmModule->getOrInsertNamedMetadata("llvm.linker.options");
-    SmallVector<llvm::Metadata*> MDNodes;
-    for (auto s : options) {
-      auto str = cast<StringAttr>(s);
-      auto *MDNode = llvm::MDString::get(context, str.getValue());
-      MDNodes.push_back(MDNode);
-    }
+  llvm::Module *llvmModule = moduleTranslation.getLLVMModule();
+  llvm::LLVMContext &context = llvmModule->getContext();
+  llvm::NamedMDNode *linkerMDNode =
+      llvmModule->getOrInsertNamedMetadata("llvm.linker.options");
+  SmallVector<llvm::Metadata *> MDNodes;
+  for (auto s : options) {
+    auto str = cast<StringAttr>(s);
+    auto *MDNode = llvm::MDString::get(context, str.getValue());
+    MDNodes.push_back(MDNode);
+  }
 
-    auto *listMDNode = llvm::MDTuple::get(context, MDNodes);
-    linkerMDNode->addOperand(listMDNode);
+  auto *listMDNode = llvm::MDTuple::get(context, MDNodes);
+  linkerMDNode->addOperand(listMDNode);
 }
 
 static LogicalResult

``````````

</details>


https://github.com/llvm/llvm-project/pull/71720