[Mlir-commits] [mlir] [mlir][ArmSME] Add constructor for `-convert-vector-to-arm-sme` pass (NFC) (PR #71705)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Nov 8 09:19:15 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Benjamin Maxwell (MacDue)

<details>
<summary>Changes</summary>

This will be needed to construct the pass downstream (i.e. in IREE).

---
Full diff: https://github.com/llvm/llvm-project/pull/71705.diff


3 Files Affected:

- (modified) mlir/include/mlir/Conversion/Passes.td (+1) 
- (modified) mlir/include/mlir/Conversion/VectorToArmSME/VectorToArmSME.h (+3) 
- (modified) mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp (+4) 


``````````diff
diff --git a/mlir/include/mlir/Conversion/Passes.td b/mlir/include/mlir/Conversion/Passes.td
index 8b64f6dbe741b93..fce168d6ce09f47 100644
--- a/mlir/include/mlir/Conversion/Passes.td
+++ b/mlir/include/mlir/Conversion/Passes.td
@@ -1204,6 +1204,7 @@ def ConvertVectorToSCF : Pass<"convert-vector-to-scf"> {
 def ConvertVectorToArmSME : Pass<"convert-vector-to-arm-sme"> {
   let summary = "Lower the operations from the vector dialect into the ArmSME "
                 "dialect";
+  let constructor = "mlir::createConvertVectorToArmSMEPass()";
   let description = [{
     Pass that converts vector dialect operations into equivalent ArmSME dialect
     operations.
diff --git a/mlir/include/mlir/Conversion/VectorToArmSME/VectorToArmSME.h b/mlir/include/mlir/Conversion/VectorToArmSME/VectorToArmSME.h
index 2108e485dae7ba7..2332311ee72cdff 100644
--- a/mlir/include/mlir/Conversion/VectorToArmSME/VectorToArmSME.h
+++ b/mlir/include/mlir/Conversion/VectorToArmSME/VectorToArmSME.h
@@ -21,6 +21,9 @@ class Pass;
 void populateVectorToArmSMEPatterns(RewritePatternSet &patterns,
                                     MLIRContext &ctx);
 
+/// Create a pass to lower operations from the vector dialect to Arm SME.
+std::unique_ptr<Pass> createConvertVectorToArmSMEPass();
+
 } // namespace mlir
 
 #endif // MLIR_CONVERSION_VECTORTOARMSME_VECTORTOARMSME_H_
diff --git a/mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp b/mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp
index 92025e9fbe82d3e..2601f31be11a32c 100644
--- a/mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp
+++ b/mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp
@@ -34,3 +34,7 @@ void ConvertVectorToArmSMEPass::runOnOperation() {
 
   (void)applyPatternsAndFoldGreedily(getOperation(), std::move(patterns));
 }
+
+std::unique_ptr<Pass> mlir::createConvertVectorToArmSMEPass() {
+  return std::make_unique<ConvertVectorToArmSMEPass>();
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/71705


More information about the Mlir-commits mailing list