[Mlir-commits] [mlir] b443992 - [mlir] Fix -Wsign-compare in NVGPUDialect.cpp (NFC)

Jie Fu llvmlistbot at llvm.org
Wed Nov 8 04:27:36 PST 2023


Author: Jie Fu
Date: 2023-11-08T20:26:33+08:00
New Revision: b44399296a7fa4323ab32739df6dbcfc6068af8f

URL: https://github.com/llvm/llvm-project/commit/b44399296a7fa4323ab32739df6dbcfc6068af8f
DIFF: https://github.com/llvm/llvm-project/commit/b44399296a7fa4323ab32739df6dbcfc6068af8f.diff

LOG: [mlir] Fix -Wsign-compare in NVGPUDialect.cpp (NFC)

/llvm-project/mlir/lib/Dialect/NVGPU/IR/NVGPUDialect.cpp:396:31: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t' (aka 'long long') [-Werror,-Wsign-compare]
  if (getCoordinates().size() !=
      ~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.

Added: 
    

Modified: 
    mlir/lib/Dialect/NVGPU/IR/NVGPUDialect.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/NVGPU/IR/NVGPUDialect.cpp b/mlir/lib/Dialect/NVGPU/IR/NVGPUDialect.cpp
index 9a671b6410948e6..c9756ae8fc11ce6 100644
--- a/mlir/lib/Dialect/NVGPU/IR/NVGPUDialect.cpp
+++ b/mlir/lib/Dialect/NVGPU/IR/NVGPUDialect.cpp
@@ -394,7 +394,7 @@ LogicalResult TmaAsyncLoadOp::verify() {
                        << " coordinates are supported.";
   }
   if (getCoordinates().size() !=
-      getTensorMapDescriptor().getType().getTensor().getRank()) {
+      size_t(getTensorMapDescriptor().getType().getTensor().getRank())) {
     return emitError() << "number of coordinates do not match with the rank of "
                           "tensor descriptor map.";
   }


        


More information about the Mlir-commits mailing list