[Mlir-commits] [mlir] [mlir][linalg][NFC] Remove linalg subset hoisting (PR #70636)

[Stella Laurenzo]

stellaraccident wrote:

Hey @matthias-springer, this chain of PRs has resulted in, if memory serves, ~6 API breakages in our project over the past week. In fact, there were no other API breakages in LLVM during the same period. While it is great to see the feature development, could I ask a couple of things (as I've been the one who has patches or had to find someone to patch every one of them):

* If possible, structure changes to LLVM in such a way that better minimizes API breaks, especially in quick succession. Having a highly fragmented linear history over the course of ~days makes it very hard to bisect and perform other project management tasks, and often the difference is not one of overhead so much as sequencing.
* When removing an API or directing people to use something that now exists and should be equivalent, please spell out migration steps and considerations in the PR description. In most of the cases I have patched, this was not super clear, and in some of them the replacement thing was structurally quite different, requiring some careful understanding to apply.

I've hesitated to bring this up for a while because I am definitely appreciative of the forward progress, but I'm hoping that by highlighting it, future work could be done in a way that gives us both the velocity and some better ability to ingest the changes.

Thanks (and sorry for the pushback -- I really do appreciate the work).

https://github.com/llvm/llvm-project/pull/70636