[Mlir-commits] [mlir] [mlir][gpu] Allow integer attribute as `dynamic_shared_memory_size` (PR #71509)

[Fabian Mora]

================
@@ -634,7 +635,9 @@ void LaunchOp::build(OpBuilder &builder, OperationState &result,
                       getBlockSizeY, getBlockSizeZ});
   if (dynamicSharedMemorySize)
     result.addOperands(dynamicSharedMemorySize);
-
+  if (dynamicSharedMemorySizeAttr)
----------------
fabianmcg wrote:

This `build` method is allowing the creation of `gpu.launch` with both dynamic and constant valid sizes, from the rest of the patch it's clear that they are mutually exclusive. A check on the verifier should be added ensuring they are exclusive.

https://github.com/llvm/llvm-project/pull/71509