[Mlir-commits] [mlir] [mlir][llvm] Add llvm.target_features features attribute (PR #71510)

[Oleksandr Alex Zinenko]

ftynse wrote:

> The LLVM attribute is just a string, so to convert between the representations will still require the string manipulation. I can experiment with other representations, but I think having the custom attribute leads to a little nicer API as the related utility functions can be attached to the attribute type.

LLVM IR attributes are notoriously unstructured, we are trying to fix that a bit in the dialect. The string manipulation can be restricted to translation where it is unavoidable, but MLIR-only manipulation can more structured. Note that I'm not proposing to use an ArrayAttr containing StringAttr, but a custom attribute _parameterized_ by an array of StringAttr.

https://github.com/llvm/llvm-project/pull/71510