[Mlir-commits] [mlir] [mlir][llvm] Add llvm.target_features features attribute (PR #71510)

[Oleksandr Alex Zinenko]

https://github.com/ftynse requested changes to this pull request.

All this string manipulation and sorting adds seemingly unnecessary complexity. Have you considered the attribute containing an array of `StringAttr` instead? Common target features can have their `StringAttr` preallocated in the dialect object, so the search would be just comparing a bunch of pointers. Less common features can still rely on string comparison. It will also give this a more MLIResque syntax.

https://github.com/llvm/llvm-project/pull/71510