[Mlir-commits] [mlir] [MLIR][Vector] Add support for distributing masked writes (PR #71482)

Lei Zhang llvmlistbot at llvm.org
Mon Nov 6 21:21:38 PST 2023


https://github.com/antiagainst requested changes to this pull request.

Hmm, I'm not sure actually this is correct. In my mental model about the masking, it's applied _close_ to the memory, immediately before/after write/read, because that's where masking really happens. So for write, the masking should match with the memory shape, not exactly the vector shape, when we have non-idenity permutation maps. I think we need inverse the map and compose with the vector shape to get the mask shape, and distribute that.. @dcaballe WDYT?

https://github.com/llvm/llvm-project/pull/71482


More information about the Mlir-commits mailing list