[Mlir-commits] [mlir] [mlir][python] value casting (PR #69644)

[Maksim Levental]

================
@@ -1112,6 +1110,7 @@ class PyConcreteAttribute : public BaseTy {
 /// bindings so such operation always exists).
 class PyValue {
 public:
+  virtual ~PyValue() = default;
----------------
makslevental wrote:

Yes, if you want to preserve `py::cast`'s correctness inside `PythonValue::maybeDownCast`. If this is to high a cost, I'm fine removing it but I would prefer to keep.

https://github.com/llvm/llvm-project/pull/69644