[Mlir-commits] [mlir] [MLIR][LLVM] Remove typed pointers from the LLVM dialect (PR #71285)

Christian Ulmann llvmlistbot at llvm.org
Mon Nov 6 00:58:57 PST 2023


================
@@ -445,7 +414,7 @@ def LLVM_StoreOp : LLVM_MemAccessOpBase<"store",
   let assemblyFormat = [{
     (`volatile` $volatile_^)? $value `,` $addr
     (`atomic` (`syncscope` `(` $syncscope^ `)`)? $ordering^)?
-    attr-dict `:` custom<StoreType>(type($value), type($addr))
+    attr-dict `:` type($value) `,` qualified(type($addr))
----------------
Dinistro wrote:

Without `qualified`, this just prints `<1>`, instead of `!llvm.ptr<1>`. Tbh, I do not fully understand the logic behind this, but I've observed similar issues in other contexts. 

https://github.com/llvm/llvm-project/pull/71285


More information about the Mlir-commits mailing list