[Mlir-commits] [mlir] [MLIR] Add support for calling conventions to LLVM::CallOp and LLVM::InvokeOp (PR #71319)

[Tobias Gysi]

https://github.com/gysit commented:

Thanks for adding proper calling convention support. PR is already looking good!

I think in addition to the test you already added, it would be great to have a round trip test for printing and parsing. mlir/test/Dialect/LLVMIR/func.mlir contains a round trip test for functions with a calling convention. I would probably add it there.



https://github.com/llvm/llvm-project/pull/71319