[Mlir-commits] [mlir] [mlir][python] remove various caching mechanisms (PR #70831)

[Jacques Pienaar]

================
@@ -57,15 +57,18 @@ void PyGlobals::loadDialectModule(llvm::StringRef dialectNamespace) {
     break;
   }
 
+  if (loaded.is_none())
+    return false;
   // Note: Iterator cannot be shared from prior to loading, since re-entrancy
   // may have occurred, which may do anything.
-  loadedDialectModulesCache.insert(dialectNamespace);
+  loadedDialectModules.insert(dialectNamespace);
+  return true;
----------------
jpienaar wrote:

Is there any follow up needed here? E.g., adding a TODO or github issue to track? (It sounds like agreement that this is only bad in what should be a very uncommon case and the added complexity/footgun doesn't warrant it).

https://github.com/llvm/llvm-project/pull/70831