[Mlir-commits] [flang] [mlir] [OpenMP][Flang] Add "IsolatedFromAbove" trait to omp.target (PR #67164)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Nov 1 11:24:07 PDT 2023


agozillon wrote:

> > However, I'm not opposed to dealing with it in a seperate patch if that is what we wish to do, just personally not a huge fan of landing this and breaking what we have working currently, as we try to find a fix.
> 
> To clarify, I was only giving a suggestion. You can fix it in this patch if that is what you want to do.

Of course, mines is just my opinion (with some context points), and not the opinion of any wider group. I'm happy to leave it up to @TIFitis to decide if he wishes to land the patches as is, this won't break any buildbot because of those tests as is, as nothing runs the tests that it would break. If we want to land the patches as is, I am happy to approve them, I've read through the changes for this current iteration. 

https://github.com/llvm/llvm-project/pull/67164


More information about the Mlir-commits mailing list