[Mlir-commits] [mlir] [mlir] Turn `memref/tensor.dim` reification into canonicalization pattern (PR #70897)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> Just a general cleanup. The main point was moving the pattern to ‘Interfaces’. Whether it’s a canonicalization pattern or not is actually not important for this cleanup. I’m curious though, do you remember why this is no longer a canonization pattern?

Basically canonicalization are meant to be local changes, but resolving dimensions of ops is a full program change. You are essentially solving for shape constraints in the whole program. So it is a fixed point, but isn't a canonicalization in the narrow sense of it. It was an effort to move things out of canonicalization to allow for more control of program transformations

https://github.com/llvm/llvm-project/pull/70897