[Mlir-commits] [mlir] 5e8ed85 - [mlir] Fix non-const lvalue reference to type 'uint64_t' cannot bind to type 'size_t' error (NFC)

[Jie Fu]

Author: Jie Fu
Date: 2023-05-27T09:53:10+08:00
New Revision: 5e8ed850d31cf18325f674d953dabf22549b85da

URL: https://github.com/llvm/llvm-project/commit/5e8ed850d31cf18325f674d953dabf22549b85da
DIFF: https://github.com/llvm/llvm-project/commit/5e8ed850d31cf18325f674d953dabf22549b85da.diff

LOG: [mlir] Fix non-const lvalue reference to type 'uint64_t' cannot bind to type 'size_t' error (NFC)

/Users/jiefu/llvm-project/mlir/lib/Bytecode/Reader/BytecodeReader.cpp:1007:39: error: non-const lvalue reference to type 'uint64_t' (aka 'unsigned long long') cannot bind to a value of unrelated type 'size_t' (aka 'unsigned long')
    if (failed(propReader.parseVarInt(count)))
                                      ^~~~~
/Users/jiefu/llvm-project/mlir/lib/Bytecode/Reader/BytecodeReader.cpp:191:39: note: passing argument to parameter 'result' here
  LogicalResult parseVarInt(uint64_t &result) {
                                      ^
/Users/jiefu/llvm-project/mlir/lib/Bytecode/Reader/BytecodeReader.cpp:1020:44: error: non-const lvalue reference to type 'uint64_t' (aka 'unsigned long long') cannot bind to a value of unrelated type 'size_t' (aka 'unsigned long')
      if (failed(offsetsReader.parseVarInt(dataSize)) ||
                                           ^~~~~~~~
/Users/jiefu/llvm-project/mlir/lib/Bytecode/Reader/BytecodeReader.cpp:191:39: note: passing argument to parameter 'result' here
  LogicalResult parseVarInt(uint64_t &result) {
                                      ^
2 errors generated.

Added: 
    

Modified: 
    mlir/lib/Bytecode/Reader/BytecodeReader.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Bytecode/Reader/BytecodeReader.cpp b/mlir/lib/Bytecode/Reader/BytecodeReader.cpp
index b4fe53e332791..4121cfa7230b5 100644
--- a/mlir/lib/Bytecode/Reader/BytecodeReader.cpp
+++ b/mlir/lib/Bytecode/Reader/BytecodeReader.cpp
@@ -1003,7 +1003,7 @@ class PropertiesSectionReader {
     if (sectionData.empty())
       return success();
     EncodingReader propReader(sectionData, fileLoc);
-    size_t count;
+    uint64_t count;
     if (failed(propReader.parseVarInt(count)))
       return failure();
     // Parse the raw properties buffer.
@@ -1016,7 +1016,7 @@ class PropertiesSectionReader {
       (void)idx;
       offsetTable.push_back(propertiesBuffers.size() - offsetsReader.size());
       ArrayRef<uint8_t> rawProperties;
-      size_t dataSize;
+      uint64_t dataSize;
       if (failed(offsetsReader.parseVarInt(dataSize)) ||
           failed(offsetsReader.parseBytes(dataSize, rawProperties)))
         return failure();