[Mlir-commits] [mlir] 1ea05c0 - [NFC] cleanup of parser

[Aart Bik]

Author: Aart Bik
Date: 2023-06-29T21:51:39-07:00
New Revision: 1ea05c0086104993bc2c2799e5f1f9c7f89ac5bf

URL: https://github.com/llvm/llvm-project/commit/1ea05c0086104993bc2c2799e5f1f9c7f89ac5bf
DIFF: https://github.com/llvm/llvm-project/commit/1ea05c0086104993bc2c2799e5f1f9c7f89ac5bf.diff

LOG: [NFC] cleanup of parser

This revision fixes a typo, where printIntegerSet() was used where it should have been parseIntegerSet().It also removes a dangling getDimsAndSymbolSSAIds() declaration that is never used.

Differential Revision: https://reviews.llvm.org/D154179

Added: 
    

Modified: 
    mlir/include/mlir/IR/OpImplementation.h
    mlir/lib/AsmParser/AffineParser.cpp
    mlir/lib/AsmParser/AsmParserImpl.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/OpImplementation.h b/mlir/include/mlir/IR/OpImplementation.h
index 4c36453f31b2f3..a05c5a5c5bfeae 100644
--- a/mlir/include/mlir/IR/OpImplementation.h
+++ b/mlir/include/mlir/IR/OpImplementation.h
@@ -1033,7 +1033,7 @@ class AsmParser {
   virtual ParseResult parseAffineMap(AffineMap &map) = 0;
 
   /// Parse an integer set instance into 'set'.
-  virtual ParseResult printIntegerSet(IntegerSet &set) = 0;
+  virtual ParseResult parseIntegerSet(IntegerSet &set) = 0;
 
   //===--------------------------------------------------------------------===//
   // Identifier Parsing

diff  --git a/mlir/lib/AsmParser/AffineParser.cpp b/mlir/lib/AsmParser/AffineParser.cpp
index 82433beb1dc672..9c6058fbaf53ee 100644
--- a/mlir/lib/AsmParser/AffineParser.cpp
+++ b/mlir/lib/AsmParser/AffineParser.cpp
@@ -58,8 +58,6 @@ class AffineParser : public Parser {
   ParseResult parseAffineMapOfSSAIds(AffineMap &map,
                                      OpAsmParser::Delimiter delimiter);
   ParseResult parseAffineExprOfSSAIds(AffineExpr &expr);
-  void getDimsAndSymbolSSAIds(SmallVectorImpl<StringRef> &dimAndSymbolSSAIds,
-                              unsigned &numDims);
 
 private:
   // Binary affine op parsing.

diff  --git a/mlir/lib/AsmParser/AsmParserImpl.h b/mlir/lib/AsmParser/AsmParserImpl.h
index 26e1f4f122ec19..aff3cb9a0b1358 100644
--- a/mlir/lib/AsmParser/AsmParserImpl.h
+++ b/mlir/lib/AsmParser/AsmParserImpl.h
@@ -457,7 +457,7 @@ class AsmParserImpl : public BaseT {
   }
 
   /// Parse an integer set instance into 'set'.
-  ParseResult printIntegerSet(IntegerSet &set) override {
+  ParseResult parseIntegerSet(IntegerSet &set) override {
     return parser.parseIntegerSetReference(set);
   }