[Mlir-commits] [mlir] 4d60c65 - Fix missing return introduced when adding support for properties in MLIR in 5e118f933b659

[Mehdi Amini]

Author: Mehdi Amini
Date: 2023-06-24T00:45:38+02:00
New Revision: 4d60c654ebe5c2c38895320cfd43c77e611b6690

URL: https://github.com/llvm/llvm-project/commit/4d60c654ebe5c2c38895320cfd43c77e611b6690
DIFF: https://github.com/llvm/llvm-project/commit/4d60c654ebe5c2c38895320cfd43c77e611b6690.diff

LOG: Fix missing return introduced when adding support for properties in MLIR in 5e118f933b659

This is a rarely used API: `matchAndRewrite()` is the usual way of using
patterns.

Added: 
    

Modified: 
    mlir/include/mlir/Conversion/LLVMCommon/Pattern.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Conversion/LLVMCommon/Pattern.h b/mlir/include/mlir/Conversion/LLVMCommon/Pattern.h
index 71bb4241976b9..7f08ec8702305 100644
--- a/mlir/include/mlir/Conversion/LLVMCommon/Pattern.h
+++ b/mlir/include/mlir/Conversion/LLVMCommon/Pattern.h
@@ -154,7 +154,7 @@ class ConvertOpToLLVMPattern : public ConvertToLLVMPattern {
   void rewrite(Operation *op, ArrayRef<Value> operands,
                ConversionPatternRewriter &rewriter) const final {
     if constexpr (SourceOp::hasProperties())
-      rewrite(cast<SourceOp>(op),
+      return rewrite(cast<SourceOp>(op),
               OpAdaptor(operands, op->getDiscardableAttrDictionary(),
                         cast<SourceOp>(op).getProperties()),
               rewriter);