[Mlir-commits] [mlir] 6e3a872 - [SetVector] Improve performance for small sizes
Dhruv Chawla
llvmlistbot at llvm.org
Sat Jun 10 00:07:02 PDT 2023
Author: Dhruv Chawla
Date: 2023-06-10T12:36:37+05:30
New Revision: 6e3a8720474528f8f752d0afbc6b8b9efab96325
URL: https://github.com/llvm/llvm-project/commit/6e3a8720474528f8f752d0afbc6b8b9efab96325
DIFF: https://github.com/llvm/llvm-project/commit/6e3a8720474528f8f752d0afbc6b8b9efab96325.diff
LOG: [SetVector] Improve performance for small sizes
SmallSetVector has an inefficiency where it does set insertions
regardless of the number of elements present within it. This contrasts
with other "Small-" containers where they use linear scan up to a
certain size "N", after which they switch to another strategy.
This patch implements this functionality in SetVector, adding a template
parameter "N" which specifies the number of elements upto which the
SetVector follows the "small" strategy. Due to the use of "if
constexpr", there is no "small" code emitted when N is 0 which makes
this a zero overhead change for users using the default behaviour.
This change also allows having SmallSetVector use DenseSet instead of
SmallDenseSet by default, which helps a little with performance.
The reason for implementing this functionality in SetVector instead of
SmallSetVector is that it allows reusing all the code that is already
there and it is just augmented with the "isSmall" checks.
This change gives a good speedup (0.4%):
https://llvm-compile-time-tracker.com/compare.php?from=086601eac266ec253bf313c746390ff3e5656132&to=acd0a72a4d3ee840f7b455d1b35d82b11ffdb3c0&stat=instructions%3Au
Differential Revision: https://reviews.llvm.org/D152497
Added:
Modified:
flang/lib/Lower/Bridge.cpp
llvm/include/llvm/ADT/SetVector.h
mlir/include/mlir/Support/LLVM.h
Removed:
################################################################################
diff --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp
index e23f89ae642f3..ee21d63c02333 100644
--- a/flang/lib/Lower/Bridge.cpp
+++ b/flang/lib/Lower/Bridge.cpp
@@ -187,7 +187,7 @@ class RuntimeTypeInfoConverter {
/// Track symbols symbols processed during and after the registration
/// to avoid infinite loops between type conversions and global variable
/// creation.
- llvm::SmallSetVector<Fortran::semantics::SymbolRef, 64> seen;
+ llvm::SmallSetVector<Fortran::semantics::SymbolRef, 32> seen;
};
class DispatchTableConverter {
diff --git a/llvm/include/llvm/ADT/SetVector.h b/llvm/include/llvm/ADT/SetVector.h
index 8d692aeba3ef1..781ca367b97e4 100644
--- a/llvm/include/llvm/ADT/SetVector.h
+++ b/llvm/include/llvm/ADT/SetVector.h
@@ -46,9 +46,19 @@ namespace llvm {
/// aware of any loss of information in this conversion. For example, setting
/// value_type to float and key_type to int can produce very surprising results,
/// but it is not explicitly disallowed.
+///
+/// The parameter N specifies the "small" size of the container, which is the
+/// number of elements upto which a linear scan over the Vector will be used
+/// when searching for elements instead of checking Set, due to it being better
+/// for performance. A value of 0 means that this mode of operation is not used,
+/// and is the default value.
template <typename T, typename Vector = std::vector<T>,
- typename Set = DenseSet<T>>
+ typename Set = DenseSet<T>, unsigned N = 0>
class SetVector {
+ // Much like in SmallPtrSet, this value should not be too high to prevent
+ // excessively long linear scans from occuring.
+ static_assert(N <= 32, "Small size should be less than or equal to 32!");
+
public:
using value_type = typename Vector::value_type;
using key_type = typename Set::key_type;
@@ -150,6 +160,17 @@ class SetVector {
/// Insert a new element into the SetVector.
/// \returns true if the element was inserted into the SetVector.
bool insert(const value_type &X) {
+ if constexpr (canBeSmall())
+ if (isSmall()) {
+ if (llvm::find(vector_, X) == vector_.end()) {
+ vector_.push_back(X);
+ if (vector_.size() > N)
+ makeBig();
+ return true;
+ }
+ return false;
+ }
+
bool result = set_.insert(X).second;
if (result)
vector_.push_back(X);
@@ -160,12 +181,21 @@ class SetVector {
template<typename It>
void insert(It Start, It End) {
for (; Start != End; ++Start)
- if (set_.insert(*Start).second)
- vector_.push_back(*Start);
+ insert(*Start);
}
/// Remove an item from the set vector.
bool remove(const value_type& X) {
+ if constexpr (canBeSmall())
+ if (isSmall()) {
+ typename vector_type::iterator I = find(vector_, X);
+ if (I != vector_.end()) {
+ vector_.erase(I);
+ return true;
+ }
+ return false;
+ }
+
if (set_.erase(X)) {
typename vector_type::iterator I = find(vector_, X);
assert(I != vector_.end() && "Corrupted SetVector instances!");
@@ -180,6 +210,10 @@ class SetVector {
/// element erased. This is the end of the SetVector if the last element is
/// erased.
iterator erase(const_iterator I) {
+ if constexpr (canBeSmall())
+ if (isSmall())
+ return vector_.erase(I);
+
const key_type &V = *I;
assert(set_.count(V) && "Corrupted SetVector instances!");
set_.erase(V);
@@ -201,8 +235,15 @@ class SetVector {
/// \returns true if any element is removed.
template <typename UnaryPredicate>
bool remove_if(UnaryPredicate P) {
- typename vector_type::iterator I =
- llvm::remove_if(vector_, TestAndEraseFromSet<UnaryPredicate>(P, set_));
+ typename vector_type::iterator I = [this, P] {
+ if constexpr (canBeSmall())
+ if (isSmall())
+ return llvm::remove_if(vector_, P);
+
+ return llvm::remove_if(vector_,
+ TestAndEraseFromSet<UnaryPredicate>(P, set_));
+ }();
+
if (I == vector_.end())
return false;
vector_.erase(I, vector_.end());
@@ -211,12 +252,20 @@ class SetVector {
/// Check if the SetVector contains the given key.
bool contains(const key_type &key) const {
+ if constexpr (canBeSmall())
+ if (isSmall())
+ return is_contained(vector_, key);
+
return set_.find(key) != set_.end();
}
/// Count the number of elements of a given key in the SetVector.
/// \returns 0 if the element is not in the SetVector, 1 if it is.
size_type count(const key_type &key) const {
+ if constexpr (canBeSmall())
+ if (isSmall())
+ return is_contained(vector_, key);
+
return set_.count(key);
}
@@ -272,7 +321,7 @@ class SetVector {
remove(*SI);
}
- void swap(SetVector<T, Vector, Set> &RHS) {
+ void swap(SetVector<T, Vector, Set, N> &RHS) {
set_.swap(RHS.set_);
vector_.swap(RHS.vector_);
}
@@ -301,6 +350,16 @@ class SetVector {
}
};
+ [[nodiscard]] static constexpr bool canBeSmall() { return N != 0; }
+
+ [[nodiscard]] bool isSmall() const { return set_.empty(); }
+
+ void makeBig() {
+ if constexpr (canBeSmall())
+ for (const auto &entry : vector_)
+ set_.insert(entry);
+ }
+
set_type set_; ///< The set.
vector_type vector_; ///< The vector.
};
@@ -308,8 +367,7 @@ class SetVector {
/// A SetVector that performs no allocations if smaller than
/// a certain size.
template <typename T, unsigned N>
-class SmallSetVector
- : public SetVector<T, SmallVector<T, N>, SmallDenseSet<T, N>> {
+class SmallSetVector : public SetVector<T, SmallVector<T, N>, DenseSet<T>, N> {
public:
SmallSetVector() = default;
@@ -325,9 +383,9 @@ class SmallSetVector
namespace std {
/// Implement std::swap in terms of SetVector swap.
-template<typename T, typename V, typename S>
-inline void
-swap(llvm::SetVector<T, V, S> &LHS, llvm::SetVector<T, V, S> &RHS) {
+template <typename T, typename V, typename S, unsigned N>
+inline void swap(llvm::SetVector<T, V, S, N> &LHS,
+ llvm::SetVector<T, V, S, N> &RHS) {
LHS.swap(RHS);
}
diff --git a/mlir/include/mlir/Support/LLVM.h b/mlir/include/mlir/Support/LLVM.h
index e55ae06a8721e..fec0debc71669 100644
--- a/mlir/include/mlir/Support/LLVM.h
+++ b/mlir/include/mlir/Support/LLVM.h
@@ -59,7 +59,7 @@ template <typename T>
class MutableArrayRef;
template <typename... PT>
class PointerUnion;
-template <typename T, typename Vector, typename Set>
+template <typename T, typename Vector, typename Set, unsigned N>
class SetVector;
template <typename T, unsigned N>
class SmallPtrSet;
@@ -123,8 +123,8 @@ using DenseMap = llvm::DenseMap<KeyT, ValueT, KeyInfoT, BucketT>;
template <typename ValueT, typename ValueInfoT = DenseMapInfo<ValueT>>
using DenseSet = llvm::DenseSet<ValueT, ValueInfoT>;
template <typename T, typename Vector = std::vector<T>,
- typename Set = DenseSet<T>>
-using SetVector = llvm::SetVector<T, Vector, Set>;
+ typename Set = DenseSet<T>, unsigned N = 0>
+using SetVector = llvm::SetVector<T, Vector, Set, N>;
template <typename AllocatorTy = llvm::MallocAllocator>
using StringSet = llvm::StringSet<AllocatorTy>;
using llvm::MutableArrayRef;
More information about the Mlir-commits
mailing list