[Mlir-commits] [mlir] f04cf6b - issue#62488: Correct some syntax errors. Leave location and custom-operation-format unchanged, because I'm not sure.

[Jeff Niu]

Author: Stevengre
Date: 2023-06-05T16:08:41-07:00
New Revision: f04cf6b73a27c84db6d1e0ecde8fa49c7bca89a4

URL: https://github.com/llvm/llvm-project/commit/f04cf6b73a27c84db6d1e0ecde8fa49c7bca89a4
DIFF: https://github.com/llvm/llvm-project/commit/f04cf6b73a27c84db6d1e0ecde8fa49c7bca89a4.diff

LOG: issue#62488: Correct some syntax errors. Leave location and custom-operation-format unchanged, because I'm not sure.

Reviewed By: Mogball

Differential Revision: https://reviews.llvm.org/D149810

Added: 
    

Modified: 
    mlir/docs/Dialects/Affine.md
    mlir/docs/LangRef.md

Removed: 
    


################################################################################
diff  --git a/mlir/docs/Dialects/Affine.md b/mlir/docs/Dialects/Affine.md
index 31bad28ef0e6d..8bc4dcfdc7eb6 100644
--- a/mlir/docs/Dialects/Affine.md
+++ b/mlir/docs/Dialects/Affine.md
@@ -142,7 +142,7 @@ Syntax:
 
 ```
 affine-map-inline
-   ::= dim-and-symbol-id-lists `->` multi-dim-affine-expr
+   ::= dim-and-symbol-value-lists `->` multi-dim-affine-expr
 ```
 
 The identifiers in the dimensions and symbols lists must be unique. These are
@@ -227,7 +227,7 @@ Syntax of semi-affine maps:
 
 ```
 semi-affine-map-inline
-   ::= dim-and-symbol-id-lists `->` multi-dim-semi-affine-expr
+   ::= dim-and-symbol-value-lists `->` multi-dim-semi-affine-expr
 ```
 
 Semi-affine maps may be defined inline at the point of use, or may be hoisted to
@@ -271,7 +271,7 @@ name.
 integer-set-id ::= `#` suffix-id
 
 integer-set-inline
-   ::= dim-and-symbol-id-lists `:` '(' affine-constraint-conjunction? ')'
+   ::= dim-and-symbol-value-lists `:` '(' affine-constraint-conjunction? ')'
 
 // Declarations of integer sets are at the top of the file.
 integer-set-decl ::= integer-set-id `=` integer-set-inline

diff  --git a/mlir/docs/LangRef.md b/mlir/docs/LangRef.md
index d29c3ced267dd..0cfe845638c3c 100644
--- a/mlir/docs/LangRef.md
+++ b/mlir/docs/LangRef.md
@@ -207,7 +207,7 @@ symbol-ref-id ::= `@` (suffix-id | string-literal) (`::` symbol-ref-id)?
 value-id-list ::= value-id (`,` value-id)*
 
 // Uses of value, e.g. in an operand list to an operation.
-value-use ::= value-id
+value-use ::= value-id (`#` decimal-literal)?
 value-use-list ::= value-use (`,` value-use)*
 ```
 
@@ -294,13 +294,13 @@ generic-operation     ::= string-literal `(` value-use-list? `)`  successor-list
                           `:` function-type
 custom-operation      ::= bare-id custom-operation-format
 op-result-list        ::= op-result (`,` op-result)* `=`
-op-result             ::= value-id (`:` integer-literal)
+op-result             ::= value-id (`:` integer-literal)?
 successor-list        ::= `[` successor (`,` successor)* `]`
 successor             ::= caret-id (`:` block-arg-list)?
 dictionary-properties ::= `<` dictionary-attribute `>`
 region-list           ::= `(` region (`,` region)* `)`
 dictionary-attribute  ::= `{` (attribute-entry (`,` attribute-entry)*)? `}`
-trailing-location     ::= (`loc` `(` location `)`)?
+trailing-location     ::= `loc` `(` location `)`
 ```
 
 MLIR introduces a uniform concept called *operations* to enable describing many