[Mlir-commits] [mlir] 1ad009a - [mlir][cmake] Comment out redundant static assert regarding VarInfo struct

Mehdi Amini llvmlistbot at llvm.org
Tue Jul 18 00:14:40 PDT 2023


Author: Amir Bishara
Date: 2023-07-18T00:14:24-07:00
New Revision: 1ad009ad3c6ae4391d15ccfd36139661bbd795a8

URL: https://github.com/llvm/llvm-project/commit/1ad009ad3c6ae4391d15ccfd36139661bbd795a8
DIFF: https://github.com/llvm/llvm-project/commit/1ad009ad3c6ae4391d15ccfd36139661bbd795a8.diff

LOG: [mlir][cmake] Comment out redundant static assert regarding VarInfo struct

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D154940

Added: 
    

Modified: 
    mlir/lib/Dialect/SparseTensor/IR/Detail/Var.h

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SparseTensor/IR/Detail/Var.h b/mlir/lib/Dialect/SparseTensor/IR/Detail/Var.h
index f381d46a2cd58a..e5d5a97b7f3555 100644
--- a/mlir/lib/Dialect/SparseTensor/IR/Detail/Var.h
+++ b/mlir/lib/Dialect/SparseTensor/IR/Detail/Var.h
@@ -386,7 +386,8 @@ class VarInfo final {
 };
 // We don't actually require this, since `VarInfo` is a proper struct
 // rather than a newtype.  But it passes, so for now we'll keep it around.
-static_assert(IsZeroCostAbstraction<VarInfo>);
+// TODO: Uncomment the static assert, it fails the build with gcc7 right now.
+// static_assert(IsZeroCostAbstraction<VarInfo>);
 
 //===----------------------------------------------------------------------===//
 enum class CreationPolicy { MustNot, May, Must };


        


More information about the Mlir-commits mailing list