[Mlir-commits] [mlir] a478193 - Remove useless / untested verifier in scf.foreach_thread (NFC)

Mehdi Amini llvmlistbot at llvm.org
Thu Jan 19 11:54:29 PST 2023


Author: Mehdi Amini
Date: 2023-01-19T19:54:10Z
New Revision: a47819345d86e5ed1e63c5f958827397218d6aad

URL: https://github.com/llvm/llvm-project/commit/a47819345d86e5ed1e63c5f958827397218d6aad
DIFF: https://github.com/llvm/llvm-project/commit/a47819345d86e5ed1e63c5f958827397218d6aad.diff

LOG: Remove useless / untested verifier in scf.foreach_thread (NFC)

Added: 
    

Modified: 
    mlir/lib/Dialect/SCF/IR/SCF.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp
index af2adb994145..18c3e7ae10af 100644
--- a/mlir/lib/Dialect/SCF/IR/SCF.cpp
+++ b/mlir/lib/Dialect/SCF/IR/SCF.cpp
@@ -1110,10 +1110,6 @@ Speculation::Speculatability ForOp::getSpeculatability() {
 //===----------------------------------------------------------------------===//
 
 LogicalResult ForeachThreadOp::verify() {
-  // Call terminator's verify to produce most informative error messages.
-  if (failed(getTerminator().verify()))
-    return failure();
-
   // Check number of outputs.
   if (getNumResults() != getOutputs().size())
     return emitOpError("produces ")


        


More information about the Mlir-commits mailing list