[Mlir-commits] [mlir] 2af1dc7 - [mlir][EmitC] Remove Pure trait from `emitc.include`

[Christopher Bate]

Author: Christopher Bate
Date: 2023-01-17T10:04:17-07:00
New Revision: 2af1dc7071ff9a49552160ab03e1422a5daa830e

URL: https://github.com/llvm/llvm-project/commit/2af1dc7071ff9a49552160ab03e1422a5daa830e
DIFF: https://github.com/llvm/llvm-project/commit/2af1dc7071ff9a49552160ab03e1422a5daa830e.diff

LOG: [mlir][EmitC] Remove Pure trait from `emitc.include`

The op `emitc.include` does not have results and thus will be elided
during canonicalization, which is not correct behavior. This change
removes the 'Pure' trait and adds a canonicalization test.

Reviewed By: jpienaar, marbre

Differential Revision: https://reviews.llvm.org/D141704

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
    mlir/test/Dialect/EmitC/ops.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
index 69863641bbd9..f6a815087673 100644
--- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
+++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
@@ -148,7 +148,7 @@ def EmitC_ConstantOp : EmitC_Op<"constant", [ConstantLike]> {
 }
 
 def EmitC_IncludeOp
-    : EmitC_Op<"include", [Pure, HasParent<"ModuleOp">]> {
+    : EmitC_Op<"include", [HasParent<"ModuleOp">]> {
   let summary = "Include operation";
   let description = [{
     The `include` operation allows to define a source file inclusion via the

diff  --git a/mlir/test/Dialect/EmitC/ops.mlir b/mlir/test/Dialect/EmitC/ops.mlir
index 08b2845ff5d9..b682aac381da 100644
--- a/mlir/test/Dialect/EmitC/ops.mlir
+++ b/mlir/test/Dialect/EmitC/ops.mlir
@@ -1,5 +1,8 @@
 // RUN: mlir-opt %s | mlir-opt | FileCheck %s
+// RUN: mlir-opt %s -canonicalize | FileCheck %s
 
+// CHECK: emitc.include <"test.h">
+// CHECK: emitc.include "test.h"
 emitc.include <"test.h">
 emitc.include "test.h"