[Mlir-commits] [mlir] 3e38fdf - Revert "[mlir][vector] Add scalable vectors support to OuterProductOp"

[Prabhdeep Singh Soni]

Author: Prabhdeep Singh Soni
Date: 2023-01-16T11:47:06-05:00
New Revision: 3e38fdf686900012c8a1875d76d2ef58c9ae43b6

URL: https://github.com/llvm/llvm-project/commit/3e38fdf686900012c8a1875d76d2ef58c9ae43b6
DIFF: https://github.com/llvm/llvm-project/commit/3e38fdf686900012c8a1875d76d2ef58c9ae43b6.diff

LOG: Revert "[mlir][vector] Add scalable vectors support to OuterProductOp"

This reverts commit be4c5ad54c929f2d817ab4a55707f0beda73a05f.

This patch did not include the test case.

Added: 
    

Modified: 
    mlir/lib/Dialect/Vector/IR/VectorOps.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
index 933945233c885..d565ecdd8735d 100644
--- a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
+++ b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
@@ -2664,18 +2664,10 @@ ParseResult OuterProductOp::parse(OpAsmParser &parser, OperationState &result) {
   if (!vLHS)
     return parser.emitError(parser.getNameLoc(),
                             "expected vector type for operand #1");
-
-  unsigned numScalableDims = vLHS.getNumScalableDims();
-  VectorType resType;
-  if (vRHS) {
-    numScalableDims += vRHS.getNumScalableDims();
-    resType = VectorType::get({vLHS.getDimSize(0), vRHS.getDimSize(0)},
-                              vLHS.getElementType(), numScalableDims);
-  } else {
-    // Scalar RHS operand
-    resType = VectorType::get({vLHS.getDimSize(0)}, vLHS.getElementType(),
-                              numScalableDims);
-  }
+  VectorType resType =
+      vRHS ? VectorType::get({vLHS.getDimSize(0), vRHS.getDimSize(0)},
+                             vLHS.getElementType())
+           : VectorType::get({vLHS.getDimSize(0)}, vLHS.getElementType());
 
   if (!result.attributes.get(OuterProductOp::getKindAttrStrName())) {
     result.attributes.append(
@@ -2711,9 +2703,6 @@ LogicalResult OuterProductOp::verify() {
       return emitOpError("expected #1 operand dim to match result dim #1");
     if (vRHS.getDimSize(0) != vRES.getDimSize(1))
       return emitOpError("expected #2 operand dim to match result dim #2");
-    if (vRHS.isScalable() != vLHS.isScalable())
-      return emitOpError("expected either all or none of vector operands #1 "
-                         "and #2 to be scalable");
   } else {
     // An AXPY operation.
     if (vRES.getRank() != 1)