[Mlir-commits] [mlir] 3948f0a - [mlir][llvm] Rename LLVMOpsInterfaces.td to LLVMInterfaces.td (NFC).

Tobias Gysi llvmlistbot at llvm.org
Mon Feb 27 23:56:25 PST 2023


Author: Tobias Gysi
Date: 2023-02-28T08:53:45+01:00
New Revision: 3948f0a0b5e5fecddf315b8de321c6a44ee7ff5c

URL: https://github.com/llvm/llvm-project/commit/3948f0a0b5e5fecddf315b8de321c6a44ee7ff5c
DIFF: https://github.com/llvm/llvm-project/commit/3948f0a0b5e5fecddf315b8de321c6a44ee7ff5c.diff

LOG: [mlir][llvm] Rename LLVMOpsInterfaces.td to LLVMInterfaces.td (NFC).

The revision renames LLVMOpsInterfaces.td since the the tablegen file
contains op and type interfaces.

Reviewed By: ftynse, Dinistro

Differential Revision: https://reviews.llvm.org/D144875

Added: 
    mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td

Modified: 
    mlir/include/mlir/Dialect/LLVMIR/CMakeLists.txt
    mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h
    mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
    mlir/lib/Dialect/LLVMIR/CMakeLists.txt
    mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Removed: 
    mlir/include/mlir/Dialect/LLVMIR/LLVMOpsInterfaces.td


################################################################################
diff  --git a/mlir/include/mlir/Dialect/LLVMIR/CMakeLists.txt b/mlir/include/mlir/Dialect/LLVMIR/CMakeLists.txt
index 54d4c82fd4521..8a2710464bc32 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/LLVMIR/CMakeLists.txt
@@ -26,12 +26,12 @@ add_public_tablegen_target(MLIRLLVMIntrinsicOpsIncGen)
 add_mlir_doc(LLVMOps LLVMOps Dialects/ -gen-op-doc)
 add_mlir_doc(LLVMIntrinsicOps LLVMIntrinsicOps Dialects/ -gen-op-doc)
 
-set(LLVM_TARGET_DEFINITIONS LLVMOpsInterfaces.td)
-mlir_tablegen(LLVMOpsInterfaces.h.inc -gen-op-interface-decls)
-mlir_tablegen(LLVMOpsInterfaces.cpp.inc -gen-op-interface-defs)
+set(LLVM_TARGET_DEFINITIONS LLVMInterfaces.td)
+mlir_tablegen(LLVMInterfaces.h.inc -gen-op-interface-decls)
+mlir_tablegen(LLVMInterfaces.cpp.inc -gen-op-interface-defs)
 mlir_tablegen(LLVMTypeInterfaces.h.inc -gen-type-interface-decls)
 mlir_tablegen(LLVMTypeInterfaces.cpp.inc -gen-type-interface-defs)
-add_public_tablegen_target(MLIRLLVMOpsInterfacesIncGen)
+add_public_tablegen_target(MLIRLLVMInterfacesIncGen)
 
 set(LLVM_TARGET_DEFINITIONS LLVMOps.td)
 mlir_tablegen(LLVMConversions.inc -gen-llvmir-conversions)

diff  --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h b/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h
index 73e0bd8363b9e..9387ad74f5312 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h
@@ -34,7 +34,7 @@
 #include "llvm/IR/Module.h"
 #include "llvm/IR/Type.h"
 
-#include "mlir/Dialect/LLVMIR/LLVMOpsInterfaces.h.inc"
+#include "mlir/Dialect/LLVMIR/LLVMInterfaces.h.inc"
 
 namespace llvm {
 class Type;

diff  --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMOpsInterfaces.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td
similarity index 91%
rename from mlir/include/mlir/Dialect/LLVMIR/LLVMOpsInterfaces.td
rename to mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td
index d9c1a41bd2b68..37e6b75ad4514 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMOpsInterfaces.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td
@@ -1,4 +1,4 @@
-//===-- LLVMOpsInterfaces.td - LLVM op interfaces ----------*- tablegen -*-===//
+//===-- LLVMInterfaces.td - LLVM Interfaces ----------------*- tablegen -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,12 +6,12 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// This is the LLVM IR interfaces definition file.
+// This file defines op and type interfaces for the LLVM dialect in MLIR.
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef LLVM_OPS_INTERFACES
-#define LLVM_OPS_INTERFACES
+#ifndef LLVMIR_INTERFACES
+#define LLVMIR_INTERFACES
 
 include "mlir/IR/OpBase.td"
 
@@ -77,4 +77,4 @@ def LLVM_PointerElementTypeInterface
 }
 
 
-#endif // LLVM_OPS_INTERFACES
+#endif // LLVMIR_INTERFACES

diff  --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
index 40455d7ab49d8..2ee34b239a52e 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
@@ -14,7 +14,7 @@
 #ifndef LLVMIR_OP_BASE
 #define LLVMIR_OP_BASE
 
-include "mlir/Dialect/LLVMIR/LLVMOpsInterfaces.td"
+include "mlir/Dialect/LLVMIR/LLVMInterfaces.td"
 include "mlir/IR/EnumAttr.td"
 include "mlir/IR/OpBase.td"
 include "mlir/Interfaces/SideEffectInterfaces.td"

diff  --git a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
index 9515b2c9990af..55c172e2565b8 100644
--- a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
+++ b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
@@ -14,7 +14,7 @@ add_mlir_dialect_library(MLIRLLVMDialect
   MLIRLLVMOpsIncGen
   MLIRLLVMTypesIncGen
   MLIRLLVMIntrinsicOpsIncGen
-  MLIRLLVMOpsInterfacesIncGen
+  MLIRLLVMInterfacesIncGen
   MLIROpenMPOpsIncGen
   intrinsics_gen
 

diff  --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
index 971cfe67c06ba..0e04b240474bb 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -46,7 +46,7 @@ using mlir::LLVM::linkage::getMaxEnumValForLinkage;
 
 static constexpr const char kElemTypeAttrName[] = "elem_type";
 
-#include "mlir/Dialect/LLVMIR/LLVMOpsInterfaces.cpp.inc"
+#include "mlir/Dialect/LLVMIR/LLVMInterfaces.cpp.inc"
 
 static auto processFMFAttr(ArrayRef<NamedAttribute> attrs) {
   SmallVector<NamedAttribute, 8> filteredAttrs(


        


More information about the Mlir-commits mailing list