[Mlir-commits] [mlir] 01b9d35 - [mlir] Use the same name as the generated parameter name (NFC).
Adrian Kuegel
llvmlistbot at llvm.org
Mon Feb 27 05:03:20 PST 2023
Author: Adrian Kuegel
Date: 2023-02-27T14:01:20+01:00
New Revision: 01b9d355d599a0aa47ee2dd49e1458d03a32a285
URL: https://github.com/llvm/llvm-project/commit/01b9d355d599a0aa47ee2dd49e1458d03a32a285
DIFF: https://github.com/llvm/llvm-project/commit/01b9d355d599a0aa47ee2dd49e1458d03a32a285.diff
LOG: [mlir] Use the same name as the generated parameter name (NFC).
When commenting for which parameter a value is passed, the same name
should be used as is used for the real parameter. In this case, the
parameter name is generated from the TransformOps.td file.
Added:
Modified:
mlir/lib/Dialect/Transform/IR/TransformOps.cpp
Removed:
################################################################################
diff --git a/mlir/lib/Dialect/Transform/IR/TransformOps.cpp b/mlir/lib/Dialect/Transform/IR/TransformOps.cpp
index 663220695a7ba..b207810edb5aa 100644
--- a/mlir/lib/Dialect/Transform/IR/TransformOps.cpp
+++ b/mlir/lib/Dialect/Transform/IR/TransformOps.cpp
@@ -992,7 +992,7 @@ void transform::SequenceOp::build(OpBuilder &builder, OperationState &state,
Value root,
SequenceBodyBuilderFn bodyBuilder) {
build(builder, state, resultTypes, failurePropagationMode, root,
- /*extraBindings=*/ValueRange());
+ /*extra_bindings=*/ValueRange());
Type bbArgType = root.getType();
buildSequenceBody(builder, state, bbArgType,
/*extraBindingTypes=*/TypeRange(), bodyBuilder);
@@ -1015,7 +1015,7 @@ void transform::SequenceOp::build(OpBuilder &builder, OperationState &state,
Type bbArgType,
SequenceBodyBuilderFn bodyBuilder) {
build(builder, state, resultTypes, failurePropagationMode, /*root=*/Value(),
- /*extraBindings=*/ValueRange());
+ /*extra_bindings=*/ValueRange());
buildSequenceBody(builder, state, bbArgType,
/*extraBindingTypes=*/TypeRange(), bodyBuilder);
}
@@ -1026,7 +1026,7 @@ void transform::SequenceOp::build(OpBuilder &builder, OperationState &state,
Type bbArgType, TypeRange extraBindingTypes,
SequenceBodyBuilderArgsFn bodyBuilder) {
build(builder, state, resultTypes, failurePropagationMode, /*root=*/Value(),
- /*extraBindings=*/ValueRange());
+ /*extra_bindings=*/ValueRange());
buildSequenceBody(builder, state, bbArgType, extraBindingTypes, bodyBuilder);
}
More information about the Mlir-commits
mailing list