[Mlir-commits] [mlir] 5cf549e - Add info about the "testing only" aspect of `--allow-unregistered-dialect` in the cl::opt desc (NFC)

Mehdi Amini llvmlistbot at llvm.org
Fri Feb 24 16:37:59 PST 2023


Author: Mehdi Amini
Date: 2023-02-24T17:37:05-07:00
New Revision: 5cf549e6b1a572f5be5a575ffb878bb927ba81b3

URL: https://github.com/llvm/llvm-project/commit/5cf549e6b1a572f5be5a575ffb878bb927ba81b3
DIFF: https://github.com/llvm/llvm-project/commit/5cf549e6b1a572f5be5a575ffb878bb927ba81b3.diff

LOG: Add info about the "testing only" aspect of `--allow-unregistered-dialect` in the cl::opt desc (NFC)

Added: 
    

Modified: 
    mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
    mlir/lib/Tools/mlir-translate/MlirTranslateMain.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Tools/mlir-opt/MlirOptMain.cpp b/mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
index 94d9a241f519a..60b5a42eb0eb1 100644
--- a/mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
+++ b/mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
@@ -240,7 +240,7 @@ LogicalResult mlir::MlirOptMain(int argc, char **argv, llvm::StringRef toolName,
 
   static cl::opt<bool> allowUnregisteredDialects(
       "allow-unregistered-dialect",
-      cl::desc("Allow operation with no registered dialects"), cl::init(false));
+      cl::desc("Allow operation with no registered dialects (discouraged: testing only!)"), cl::init(false));
 
   static cl::opt<bool> showDialects(
       "show-dialects", cl::desc("Print the list of registered dialects"),

diff  --git a/mlir/lib/Tools/mlir-translate/MlirTranslateMain.cpp b/mlir/lib/Tools/mlir-translate/MlirTranslateMain.cpp
index 5e460ed13fd62..8fc3abea47f21 100644
--- a/mlir/lib/Tools/mlir-translate/MlirTranslateMain.cpp
+++ b/mlir/lib/Tools/mlir-translate/MlirTranslateMain.cpp
@@ -39,7 +39,7 @@ LogicalResult mlir::mlirTranslateMain(int argc, char **argv,
 
   static llvm::cl::opt<bool> allowUnregisteredDialects(
       "allow-unregistered-dialect",
-      llvm::cl::desc("Allow operation with no registered dialects"),
+      llvm::cl::desc("Allow operation with no registered dialects (discouraged: testing only!)"),
       llvm::cl::init(false));
 
   static llvm::cl::opt<bool> splitInputFile(


        


More information about the Mlir-commits mailing list