[Mlir-commits] [mlir] 58d246a - [mlir][spirv] Drop outdated TODO comment

[Jakub Kuderski]

Author: Jakub Kuderski
Date: 2023-02-13T11:06:07-05:00
New Revision: 58d246a27b8c9b56e525560ef3d2db11afb251f2

URL: https://github.com/llvm/llvm-project/commit/58d246a27b8c9b56e525560ef3d2db11afb251f2
DIFF: https://github.com/llvm/llvm-project/commit/58d246a27b8c9b56e525560ef3d2db11afb251f2.diff

LOG: [mlir][spirv] Drop outdated TODO comment

We do not plan to handle wide vector types with SPIR-V arrays anymore.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D143777

Added: 
    

Modified: 
    mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
index f85f76d10066c..0a1c887733d04 100644
--- a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
+++ b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
@@ -252,8 +252,6 @@ convertVectorType(const spirv::TargetEnv &targetEnv,
     return convertScalarType(targetEnv, options, scalarType, storageClass);
 
   if (!spirv::CompositeType::isValid(type)) {
-    // TODO: Vector types with more than four elements can be translated into
-    // array types.
     LLVM_DEBUG(llvm::dbgs() << type << " illegal: > 4-element unimplemented\n");
     return nullptr;
   }